Correct inactive ActionList.Item behavior in NavList and SelectPanel contexts#5866
Correct inactive ActionList.Item behavior in NavList and SelectPanel contexts#5866
Conversation
…ooltip when the role is 'menu' or 'listbox'
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
🦋 Changeset detectedLatest commit: 075695f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…eact into mp/fix-inactive-actionlist-bugs
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371303 |
|
🔴 golden-jobs completed with status |
…eact into mp/fix-inactive-actionlist-bugs
|
Failing integration should be fixed by https://github.com/github/github/pull/371483 |
Nice! let's merge the fix in gh/gh before merging this pr as to not block main 🙏 |
… determining whether to show ActionList.TrailingAction
…contexts (#5866) Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
…contexts (#5866) Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Note
The fix for SelectPanel will only be available with the
"primer_react_select_panel_with_modern_action_list"feature flag. The deprecated ActionList did not support inactive items.Helpful context
Slack thread that kicked this off
A11y Office Hours recording and recap
A11y Office Hours notes
Demo
Before
Kapture.2025-04-02.at.19.00.22.mp4
After
Kapture.2025-04-02.at.18.49.23.mp4
Changelog
New
Changed
ActionListwrapped in anActionMenuorSelectPanel?”) to decide between a tooltip or inline inactive message, we now check theroleonActionList.roleis"menu"or"listbox", the inactive message is rendered inline (e.g. inActionMenuorSelectPanel)role-based logic fixes inactive NavList item behavior:role-based logic fixes inactive SelectPanel item behavior:SelectPanelitems when using the modernActionList. The deprecatedActionListdoes not support inactive items.role-based logic to determine whetherActionList.TrailingActionis allowed inside an itemaria-describedbyandaria-labelledbyassociations for tooltip buttons on inactive items:aria-describedby→ item label ("Item 1"),aria-labelledby→ inactive message ("Unavailable due to an outage")aria-labelledby→ item label,aria-describedby→ inactive messageRemoved
Rollout strategy
Testing & Reviewing
Merge checklist